Skip to content

build: bump trustify-da-api-model to 2.0.7#342

Merged
soul2zimate merged 1 commit into
guacsec:mainfrom
soul2zimate:bump_trustify-da-api-model
Mar 9, 2026
Merged

build: bump trustify-da-api-model to 2.0.7#342
soul2zimate merged 1 commit into
guacsec:mainfrom
soul2zimate:bump_trustify-da-api-model

Conversation

@soul2zimate

@soul2zimate soul2zimate commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

build: bump trustify-da-api-model to 2.0.7

replace #333.

I can't get a meaningful CI result from #333, although it was rebased to latest main

Hi @ruromero, could you approve this one?

@qodo-code-review

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Upgrade trustify-da-api-model dependency to 2.0.7

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Upgrade trustify-da-api-model dependency from 2.0.4 to 2.0.7
• Incorporates latest API model improvements and fixes
Diagram
flowchart LR
  pom["pom.xml"] -- "update version property" --> dep["trustify-da-api-model 2.0.7"]
  old["2.0.4"] -- "replaced by" --> new["2.0.7"]
Loading

Grey Divider

File Changes

1. pom.xml Dependencies +1/-1

Bump trustify-da-api-model version property

• Updated trustify-da-api-model.version property from 2.0.4 to 2.0.7
• Single line change in Maven properties section

pom.xml


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. JPMS/API compatibility risk 🐞 Bug ⛯ Reliability
Description
The project directly requires the JPMS module trustifyda.api and imports
io.github.guacsec.trustifyda.api.v5.* types that are expected to come from
trustify-da-api-model; if 2.0.7 changes the module name or moves/removes the v5 packages, the
build will fail at compile time.
Code

pom.xml[21]

+    <trustify-da-api-model.version>2.0.7</trustify-da-api-model.version>
Evidence
The PR changes the version of trustify-da-api-model used on the compile classpath. The codebase
has an explicit JPMS requires transitive trustifyda.api; and uses
io.github.guacsec.trustifyda.api.v5.AnalysisReport, so it depends on the dependency continuing to
provide those exact module/package names.

pom.xml[14-28]
pom.xml[121-128]
src/main/java/module-info.java[1-14]
src/main/java/io/github/guacsec/trustifyda/Api.java[17-57]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The project is a JPMS module that explicitly requires `trustifyda.api` and uses `io.github.guacsec.trustifyda.api.v5.*` model types. After bumping `trustify-da-api-model` to 2.0.7, the build will fail if that artifact changed its JPMS module name or moved/removed the `v5` package.

### Issue Context
This PR only changes the dependency version, so any breaking change will appear as a compile-time failure in module resolution (`requires trustifyda.api`) or missing types (`io.github.guacsec.trustifyda.api.v5.AnalysisReport`, etc.).

### Fix Focus Areas
- pom.xml[21-21]
- pom.xml[121-128]
- src/main/java/module-info.java[1-14]
- src/main/java/io/github/guacsec/trustifyda/Api.java[17-57]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@soul2zimate
soul2zimate merged commit 21a1dac into guacsec:main Mar 9, 2026
28 of 39 checks passed
@soul2zimate
soul2zimate deleted the bump_trustify-da-api-model branch March 9, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants